Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PR locally from fork for PR# 997 #1026

Merged
merged 6 commits into from
Dec 8, 2024
Merged

Create PR locally from fork for PR# 997 #1026

merged 6 commits into from
Dec 8, 2024

Conversation

vishiy
Copy link
Contributor

@vishiy vishiy commented Dec 8, 2024

PR Description

New Feature Checklist

  • List telemetry added about the feature.
  • Link to the one-pager about the feature.
  • List any tasks necessary for release (3P docs, AKS RP chart changes, etc.) after merging the PR.
  • Attach results of scale and perf testing.

Tests Checklist

  • Have end-to-end Ginkgo tests been run on your cluster and passed? To bootstrap your cluster to run the tests, follow these instructions.
    • Labels used when running the tests on your cluster:
      • operator
      • windows
      • arm64
      • arc-extension
      • fips
  • Have new tests been added? For features, have tests been added for this feature? For fixes, is there a test that could have caught this issue and could validate that the fix works?

@vishiy vishiy requested a review from a team as a code owner December 8, 2024 07:06
@github-actions github-actions bot added the size/L label Dec 8, 2024
@vishiy
Copy link
Contributor Author

vishiy commented Dec 8, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vishiy
Copy link
Contributor Author

vishiy commented Dec 8, 2024

#997

@vishiy vishiy merged commit 7637ff8 into main Dec 8, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants